lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250610135338.580aa25b@kernel.org> Date: Tue, 10 Jun 2025 13:53:38 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com> Cc: linux-pci@...r.kernel.org, Potnuri Bharat Teja <bharat@...lsio.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/3] cxgb3: Replace PCI related literals with defines & correct variable On Tue, 10 Jun 2025 13:32:03 +0300 Ilpo Järvinen wrote: > Replace literals 0, 2, 0x1425 with PCI_VENDOR_ID, PCI_DEVICE_ID, > PCI_VENDOR_ID_CHELSIO, respectively. Rename devid variable to vendor_id > to remove confusion. This series is missing a cover letter. An explanation of why you're touching this very very old driver is in order, and please comment on whether you can test this on real HW, because we don't like refactoring of very old code: Quoting documentation: Clean-up patches ~~~~~~~~~~~~~~~~ Netdev discourages patches which perform simple clean-ups, which are not in the context of other work. For example: * Addressing ``checkpatch.pl`` warnings * Addressing :ref:`Local variable ordering<rcs>` issues * Conversions to device-managed APIs (``devm_`` helpers) This is because it is felt that the churn that such changes produce comes at a greater cost than the value of such clean-ups. Conversely, spelling and grammar fixes are not discouraged. See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches -- pw-bot: cr
Powered by blists - more mailing lists