netdev - Re: [PATCH iproute2-next v2 1/4] ip: ipstats: Iterate all xstats attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aEfba37PsZm8s99u@shredder>
Date: Tue, 10 Jun 2025 10:14:51 +0300
From: Ido Schimmel <idosch@...dia.com>
To: Petr Machata <petrm@...dia.com>
Cc: David Ahern <dsahern@...il.com>, netdev@...r.kernel.org,
	Nikolay Aleksandrov <razor@...ckwall.org>,
	bridge@...ts.linux-foundation.org
Subject: Re: [PATCH iproute2-next v2 1/4] ip: ipstats: Iterate all xstats
 attributes

On Mon, Jun 09, 2025 at 06:05:09PM +0200, Petr Machata wrote:
> ipstats_stat_desc_show_xstats() operates by first parsing the attribute
> stream into a type-indexed table, and then accessing the right attribute.
> But bridge VLAN stats are given as several BRIDGE_XSTATS_VLAN attributes,
> one per VLAN. With the above approach to parsing, only one of these
> attributes would be shown. Instead, iterate the stream of attributes and
> call the show_cb for each one with a matching type.
> 
> Signed-off-by: Petr Machata <petrm@...dia.com>

Reviewed-by: Ido Schimmel <idosch@...dia.com>