netdev - Re: [PATCH ipsec 0/2] xfrm: fixes for xfrm_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aEfk6oq05IRuKpc5@gauss3.secunet.de>
Date: Tue, 10 Jun 2025 09:55:22 +0200
From: Steffen Klassert <steffen.klassert@...unet.com>
To: Sabrina Dubroca <sd@...asysnail.net>
CC: <netdev@...r.kernel.org>, Antony Antony <antony.antony@...unet.com>,
	Tobias Brunner <tobias@...ongswan.org>, Florian Westphal <fw@...len.de>
Subject: Re: [PATCH ipsec 0/2] xfrm: fixes for xfrm_state_find under
 preemption

On Fri, May 23, 2025 at 05:11:16PM +0200, Sabrina Dubroca wrote:
> While looking at the pcpu_id changes, I found two issues that can
> happen if we get preempted and the cpu_id changes. The second patch
> takes care of both problems. The first patch also makes sure we don't
> use state_ptrs uninitialized, which could currently happen. syzbot
> seems to have hit this issue [1].
> 
> [1] https://syzkaller.appspot.com/bug?extid=7ed9d47e15e88581dc5b
> 
> Sabrina Dubroca (2):
>   xfrm: state: initialize state_ptrs earlier in xfrm_state_find
>   xfrm: state: use a consistent pcpu_id for xfrm_state_find

Applied, thanks a lot!