[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1f1ecf24-9be1-4822-83f2-104420d39933@nvidia.com>
Date: Wed, 11 Jun 2025 08:06:38 +0300
From: Gal Pressman <gal@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
Andrew Lunn <andrew+netdev@...n.ch>, netdev@...r.kernel.org,
Andrew Lunn <andrew@...n.ch>, Simon Horman <horms@...nel.org>,
Shuah Khan <shuah@...nel.org>, Joe Damato <jdamato@...tly.com>,
linux-kselftest@...r.kernel.org, Nimrod Oren <noren@...dia.com>
Subject: Re: [PATCH net v2 2/2] selftests: drv-net: rss_ctx: Add test for
ntuple rules targeting default RSS context
On 11/06/2025 0:32, Jakub Kicinski wrote:
> On Mon, 9 Jun 2025 15:02:50 +0300 Gal Pressman wrote:
>> The test was written by AI, and reviewed by humans.
>
> Please use pylint and avoid adding new warnings:
Ack.
>
> tools/testing/selftests/drivers/net/hw/rss_ctx.py:788:0: C0301: Line too long (103/100) (line-too-long)
Are you sure you want to blindly break this line?
It's a single string.
> tools/testing/selftests/drivers/net/hw/rss_ctx.py:769:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise KsftSkipEx('Not enough queues for the test') from exc' (raise-missing-from)
Cool, didn't know python can do that.
Powered by blists - more mailing lists