netdev - Re: [PATCH] net: Add new iccnet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <83e44167-43eb-4abd-b536-c2e290ab4382@lunn.ch>
Date: Wed, 11 Jun 2025 18:38:57 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Khalid Mughal <khalid.mughal@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
	Sridhar Samudrala <sridhar.samudrala@...el.com>
Subject: Re: [PATCH] net: Add new iccnet driver

On Wed, Jun 11, 2025 at 08:54:02AM -0700, Khalid Mughal wrote:
> Intel(R) IPU ICCNET (Inter-Complex Communication Network) Driver:
> 
> The iccnet (Inter-Core Communication Network) driver enables sideband
> channel communication between the Management-Complex and the
> Compute-Complex, both powered by ARMv8 CPUs, on the Intel IPU
> (Infrastructure Processing Unit). The driver establishes descriptor
> rings for transmission and reception using a shared memory region
> accessible to both CPU complexes. The TX ring of one CPU maps
> directly to the RX ring of the other CPU.

https://www.spinics.net/lists/netdev/msg1000950.html

I suspect the developer was a student on a placement at TI for a
while, so it had the typical student code problems, and he had
problems thinking about the big picture, a generic solution rather
than a solution specific to TIs use case.

Please could you read through the comments i made to various versions
of that patchset and see what applies to what you are doing. Two
similar systems within a year suggests we need a generic shared memory
solution, or at least a shared core library which can then be wrapped
for individual use cases.

> v2:
> - Fixed issues highlighted by Marcin Szycik
> v3:
> - Fixed internal-kbuild-all build warning
> v4:
> - Changed iccnet header padding

As far as i know, these never made it to the list, so don't exist. It
is good it had internal review, but please don't pollute the commit
with stuff nobody else can see.

     Andrew