netdev - Re: [net-next PATCH 3/6] fbnic: Replace 'link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKgT0UcgKprPn79=qmoztPgm+B8W3iouDhPZYRW0qvThVv-exw@mail.gmail.com>
Date: Wed, 11 Jun 2025 14:17:33 -0700
From: Alexander Duyck <alexander.duyck@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, linux@...linux.org.uk, hkallweit1@...il.com, 
	andrew@...n.ch, davem@...emloft.net, pabeni@...hat.com
Subject: Re: [net-next PATCH 3/6] fbnic: Replace 'link_mode' with 'aui'

On Wed, Jun 11, 2025 at 2:00 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue, 10 Jun 2025 07:51:28 -0700 Alexander Duyck wrote:
> > -static void fbnic_pcs_get_fw_settings(struct fbnic_dev *fbd)
> > +static void fbnic_mac_get_fw_settings(struct fbnic_dev *fbd, u8 *aui, u8 *fec)
>
> We get a transient "unused function" warning on this patch.
> Looks like the next patch adds a declaration in the header,
> let's do it here to avoid the warning?
> --
> pw-bot: cr

Actually it is a bigger bug as we aren't pulling the values from the
FW as it looks like I accidentally pulled things forward a bit. I am
running some tests now with the fix. It is pretty small as I just have
to not pull out the use of the function in the MAC code until the next
patch.