netdev - Re: [PATCH net-next 06/12] net: txgbevf: init interrupts and request irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202506120658.JRvrXNTk-lkp@intel.com>
Date: Thu, 12 Jun 2025 06:39:41 +0800
From: kernel test robot <lkp@...el.com>
To: Mengyuan Lou <mengyuanlou@...-swift.com>, netdev@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev, kuba@...nel.org,
	pabeni@...hat.com, horms@...nel.org, andrew+netdev@...n.ch,
	duanqiangwen@...-swift.com, linglingzhang@...stnetic.com,
	jiawenwu@...-swift.com, Mengyuan Lou <mengyuanlou@...-swift.com>
Subject: Re: [PATCH net-next 06/12] net: txgbevf: init interrupts and request
 irqs

Hi Mengyuan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Mengyuan-Lou/net-libwx-add-mailbox-api-for-wangxun-vf-drivers/20250611-165134
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250611083559.14175-7-mengyuanlou%40net-swift.com
patch subject: [PATCH net-next 06/12] net: txgbevf: init interrupts and request irqs
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20250612/202506120658.JRvrXNTk-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250612/202506120658.JRvrXNTk-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506120658.JRvrXNTk-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/wangxun/txgbevf/txgbevf_main.c:77:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
      77 |                 default:
         |                 ^
   drivers/net/ethernet/wangxun/txgbevf/txgbevf_main.c:77:3: note: insert 'break;' to avoid fall-through
      77 |                 default:
         |                 ^
         |                 break; 
   1 warning generated.


vim +77 drivers/net/ethernet/wangxun/txgbevf/txgbevf_main.c

    46	
    47	static void txgbevf_set_num_queues(struct wx *wx)
    48	{
    49		u32 def_q = 0, num_tcs = 0;
    50		u16 rss, queue;
    51		int ret = 0;
    52	
    53		/* Start with base case */
    54		wx->num_rx_queues = 1;
    55		wx->num_tx_queues = 1;
    56	
    57		spin_lock_bh(&wx->mbx.mbx_lock);
    58		/* fetch queue configuration from the PF */
    59		ret = wx_get_queues_vf(wx, &num_tcs, &def_q);
    60		spin_unlock_bh(&wx->mbx.mbx_lock);
    61	
    62		if (ret)
    63			return;
    64	
    65		/* we need as many queues as traffic classes */
    66		if (num_tcs > 1) {
    67			wx->num_rx_queues = num_tcs;
    68		} else {
    69			rss = min_t(u16, num_online_cpus(), TXGBEVF_MAX_RSS_NUM);
    70			queue = min_t(u16, wx->mac.max_rx_queues, wx->mac.max_tx_queues);
    71			rss = min_t(u16, queue, rss);
    72	
    73			switch (wx->vfinfo->vf_api) {
    74			case wx_mbox_api_13:
    75				wx->num_rx_queues = rss;
    76				wx->num_tx_queues = rss;
  > 77			default:
    78				break;
    79			}
    80		}
    81	}
    82	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki