lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <aElHrRb5Vk7PzEAs@home.paul.comp> Date: Wed, 11 Jun 2025 12:09:01 +0300 From: Paul Fertser <fercerpav@...il.com> To: kalavakunta.hari.prasad@...il.com Cc: sam@...dozajonas.com, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, horms@...nel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, npeacock@...a.com, hkalavakunta@...a.com Subject: Re: [PATCH net-next] net: ncsi: Fix buffer overflow in fetching version id Hello Hari, On Tue, Jun 10, 2025 at 12:33:38PM -0700, kalavakunta.hari.prasad@...il.com wrote: > From: Hari Kalavakunta <kalavakunta.hari.prasad@...il.com> > > In NC-SI spec v1.2 section 8.4.44.2, the firmware name doesn't > need to be null terminated while its size occupies the full size > of the field. Fix the buffer overflow issue by adding one > additional byte for null terminator. > > Signed-off-by: Hari Kalavakunta <kalavakunta.hari.prasad@...il.com> You seem to be surprisingly persistent about ignoring my remarks on your commit message. So be it, since the code looks correct and reliable, fixes a real life bug, and actually applies to the right tree now, Reviewed-by: Paul Fertser <fercerpav@...il.com>
Powered by blists - more mailing lists