netdev - Re: [PATCH net-next v2] net: sysfs: Implement is_visible for phys_(port_id, port_name, switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <be52bdf3f1f4786f73b618369f63ce035ce8b955@linux.dev>
Date: Thu, 12 Jun 2025 08:51:52 +0000
From: "Yajun Deng" <yajun.deng@...ux.dev>
To: "Paolo Abeni" <pabeni@...hat.com>, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 horms@...nel.org
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: sysfs: Implement is_visible for
 phys_(port_id, port_name, switch_id)

May 27, 2025 at 2:08 PM, "Paolo Abeni" <pabeni@...hat.com> wrote:



> 
> On 5/21/25 4:08 PM, Yajun Deng wrote:
> 
> > 
> > phys_port_id_show, phys_port_name_show and phys_switch_id_show would
> > 
> >  return -EOPNOTSUPP if the netdev didn't implement the corresponding
> > 
> >  method.
> > 
> >  
> > 
> >  There is no point in creating these files if they are unsupported.
> > 
> >  
> > 
> >  Put these attributes in netdev_phys_group and implement the is_visible
> > 
> >  method. make phys_(port_id, port_name, switch_id) invisible if the netdev
> > 
> >  dosen't implement the corresponding method.
> > 
> >  
> > 
> >  Signed-off-by: Yajun Deng <yajun.deng@...ux.dev>
> > 
> 
> I fear that some orchestration infra depends on the files existence -
> 
> i.e. scripts don't tolerate the files absence, deal only with I/O errors
> 
> after open.
> 
> It feel a bit too dangerous to merge a change that could break
> 
> user-space this late. Let's defer it to the beginning of the next cycle.
> 

Ping.

> Paolo
>