netdev - Re: [PATCH v3 0/5] io_uring cmd for tx timestamps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ff6b1e8-ea46-47db-aa52-65f252550396@gmail.com>
Date: Thu, 12 Jun 2025 10:15:50 +0100
From: Pavel Begunkov <asml.silence@...il.com>
To: io-uring@...r.kernel.org, Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc: netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
 Kuniyuki Iwashima <kuniyu@...zon.com>, Paolo Abeni <pabeni@...hat.com>,
 Willem de Bruijn <willemb@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Richard Cochran <richardcochran@...il.com>,
 Stanislav Fomichev <sdf@...ichev.me>, Jason Xing <kerneljasonxing@...il.com>
Subject: Re: [PATCH v3 0/5] io_uring cmd for tx timestamps

On 6/12/25 10:09, Pavel Begunkov wrote:
> Vadim Fedorenko suggested to add an alternative API for receiving
> tx timestamps through io_uring. The series introduces io_uring socket
> cmd for fetching tx timestamps, which is a polled multishot request,
> i.e. internally polling the socket for POLLERR and posts timestamps
> when they're arrives. For the API description see Patch 5.
> 
> It reuses existing timestamp infra and takes them from the socket's
> error queue. For networking people the important parts are Patch 1,
> and io_uring_cmd_timestamp() from Patch 5 walking the error queue.
> 
> It should be reasonable to take it through the io_uring tree once
> we have consensus, but let me know if there are any concerns.
> 
> v3: Add a flag to distinguish sw vs hw timestamp. skb_get_tx_timestamp()
>      from Patch 1 now returns the indication of that, and in Patch 5
>      it's converted into a io_uring CQE bit flag.

FWIW, it's a relatively small change, but I dropped all review tags.

Also I pruned the test I've been using (derived from the tx-timestamp
selftest). Pushed it here:

https://github.com/isilence/liburing/tree/tx-timestamp

-- 
Pavel Begunkov