netdev - Re: [PATCH net-next 05/14] net: ipv6: Make udp_tunnel6_xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <edbb9a85-c392-4224-927e-6597c686a8bd@blackwall.org>
Date: Thu, 12 Jun 2025 13:29:48 +0300
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Petr Machata <petrm@...dia.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...il.com>,
 netdev@...r.kernel.org
Cc: Simon Horman <horms@...nel.org>, Ido Schimmel <idosch@...dia.com>,
 mlxsw@...dia.com
Subject: Re: [PATCH net-next 05/14] net: ipv6: Make udp_tunnel6_xmit_skb()
 void

On 6/9/25 23:50, Petr Machata wrote:
> The function always returns zero, thus the return value does not carry any
> signal. Just make it void.
> 
> Most callers already ignore the return value. However:
> 
> - Refold arguments of the call from sctp_v6_xmit() so that they fit into
>    the 80-column limit.
> 
> - tipc_udp_xmit() initializes err from the return value, but that should
>    already be always zero at that point. So there's no practical change, but
>    elision of the assignment prompts a couple more tweaks to clean up the
>    function.
> 
> Signed-off-by: Petr Machata <petrm@...dia.com>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>
> ---
> 
> Notes:
> CC:Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
> CC:linux-sctp@...r.kernel.org
> CC:Jon Maloy <jmaloy@...hat.com>
> CC:tipc-discussion@...ts.sourceforge.net
> 
>   include/net/udp_tunnel.h  | 14 +++++++-------
>   net/ipv6/ip6_udp_tunnel.c | 15 +++++++--------
>   net/sctp/ipv6.c           |  7 ++++---
>   net/tipc/udp_media.c      | 10 +++++-----
>   4 files changed, 23 insertions(+), 23 deletions(-)
> 

Reviewed-by: Nikolay Aleksandrov <razor@...ckwall.org>