netdev - Re: [PATCH v2] net/sched: fix use-after-free in taprio_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLQVzEYND74vSPRVpedodME+F-+HME4YmhnA46PdFuwrw@mail.gmail.com>
Date: Thu, 12 Jun 2025 04:46:53 -0700
From: Eric Dumazet <edumazet@...gle.com>
To: Hyunwoo Kim <imv4bel@...il.com>
Cc: vinicius.gomes@...el.com, jhs@...atatu.com, xiyou.wangcong@...il.com, 
	jiri@...nulli.us, davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, 
	horms@...nel.org, vladimir.oltean@....com, netdev@...r.kernel.org, 
	v4bel@...ori.io
Subject: Re: [PATCH v2] net/sched: fix use-after-free in taprio_dev_notifier

On Thu, Jun 12, 2025 at 4:17 AM Hyunwoo Kim <imv4bel@...il.com> wrote:
>
> Since taprio’s taprio_dev_notifier() isn’t protected by an
> RCU read-side critical section, a race with advance_sched()
> can lead to a use-after-free.
>
> Adding rcu_read_lock() inside taprio_dev_notifier() prevents this.
>
> Fixes: fed87cc6718a ("net/sched: taprio: automatically calculate queueMaxSDU based on TC gate durations")
> Cc: stable@...r.kernel.org
> Signed-off-by: Hyunwoo Kim <imv4bel@...il.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>