netdev - Re: [PATCH] mac802154_hwsim: allow users to specify the number of simulated radios dynamically instead of the previously hardcoded value of 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK-6q+jDa4=DFndeQVzpaWemDPxf5Pr6Mrimm8ruDSsTriOmSw@mail.gmail.com>
Date: Thu, 12 Jun 2025 08:20:24 -0400
From: Alexander Aring <aahringo@...hat.com>
To: Ramon Fontes <ramonreisfontes@...il.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, 
	linux-wpan@...r.kernel.org, alex.aring@...il.com, miquel.raynal@...tlin.com, 
	netdev@...r.kernel.org
Subject: Re: [PATCH] mac802154_hwsim: allow users to specify the number of
 simulated radios dynamically instead of the previously hardcoded value of 2

Hi,

On Tue, Jun 10, 2025 at 6:54 AM Ramon Fontes <ramonreisfontes@...il.com> wrote:
>
> Add a module parameter radios to allow users to configure the number
> of virtual radios created by mac802154_hwsim at module load time.
> This replaces the previously hardcoded value of 2.
>
> * Added a new module parameter radios
> * Modified the loop in hwsim_probe()
> * Updated log message in hwsim_probe()
>
> Signed-off-by: Ramon Fontes <ramonreisfontes@...il.com>
> ---
>  drivers/net/ieee802154/mac802154_hwsim.c | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ieee802154/mac802154_hwsim.c b/drivers/net/ieee802154/mac802154_hwsim.c
> index 1cab20b5a..bf6554669 100644
> --- a/drivers/net/ieee802154/mac802154_hwsim.c
> +++ b/drivers/net/ieee802154/mac802154_hwsim.c
> @@ -27,6 +27,10 @@
>  MODULE_DESCRIPTION("Software simulator of IEEE 802.15.4 radio(s) for mac802154");
>  MODULE_LICENSE("GPL");
>
> +static unsigned int radios = 2;
> +module_param(radios, int, 0444);

this needs to be uint, and I think you had that in the last versions
as I said in the last version.

Sorry but letting that through there will be the next bot detecting
this and somebody else fixing it and I kind of was aware of it.
(Now I have some half of an idea to maybe get rid of that parameter).

- Alex