netdev - RE: [Intel-wired-lan] [PATCH iwl-next v1] igbvf: remove unused interrupt counter fields from struct igbvf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA3PR11MB8986E1AC705BCC56FF5D6273E574A@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Thu, 12 Jun 2025 16:35:37 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: Kohei Enju <enjuk@...zon.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, Andrew Lunn
	<andrew+netdev@...n.ch>, "David S . Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Kohei Enju <kohei.enju@...il.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v1] igbvf: remove unused
 interrupt counter fields from struct igbvf_adapter



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of Kohei Enju
> Sent: Thursday, June 12, 2025 6:14 PM
> To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@...el.com>
> Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; Andrew
> Lunn <andrew+netdev@...n.ch>; David S . Miller <davem@...emloft.net>;
> Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>;
> Paolo Abeni <pabeni@...hat.com>; Kohei Enju <kohei.enju@...il.com>;
> Kohei Enju <enjuk@...zon.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next v1] igbvf: remove unused
> interrupt counter fields from struct igbvf_adapter
> 
> Remove `int_counter0` and `int_counter1` from struct igbvf_adapter
> since they are only incremented in interrupt handlers
> igbvf_intr_msix_rx() and igbvf_msix_other(), but never read or used
> anywhere in the driver.
> 
> Note that igbvf_intr_msix_tx() does not have similar counter
> increments, suggesting that these were likely overlooked during
> development.
> 
> Eliminate the fields and their unnecessary accesses in interrupt
> handlers.
> 
> Tested-by: Kohei Enju <enjuk@...zon.com>
> Signed-off-by: Kohei Enju <enjuk@...zon.com>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>

> ---
>  drivers/net/ethernet/intel/igbvf/igbvf.h  | 2 --
> drivers/net/ethernet/intel/igbvf/netdev.c | 4 ----
>  2 files changed, 6 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igbvf/igbvf.h
> b/drivers/net/ethernet/intel/igbvf/igbvf.h
> index ca6e44245a7b..ba9c3fee6da7 100644
> --- a/drivers/net/ethernet/intel/igbvf/igbvf.h
> +++ b/drivers/net/ethernet/intel/igbvf/igbvf.h
> @@ -238,8 +238,6 @@ struct igbvf_adapter {
>  	int int_mode;
>  	u32 eims_enable_mask;
>  	u32 eims_other;
> -	u32 int_counter0;
> -	u32 int_counter1;
> 
>  	u32 eeprom_wol;
>  	u32 wol;
> diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c
> b/drivers/net/ethernet/intel/igbvf/netdev.c
> index beb01248600f..33104408007a 100644
> --- a/drivers/net/ethernet/intel/igbvf/netdev.c
> +++ b/drivers/net/ethernet/intel/igbvf/netdev.c
> @@ -855,8 +855,6 @@ static irqreturn_t igbvf_msix_other(int irq, void
> *data)
>  	struct igbvf_adapter *adapter = netdev_priv(netdev);
>  	struct e1000_hw *hw = &adapter->hw;
> 
> -	adapter->int_counter1++;
> -
>  	hw->mac.get_link_status = 1;
>  	if (!test_bit(__IGBVF_DOWN, &adapter->state))
>  		mod_timer(&adapter->watchdog_timer, jiffies + 1); @@ -
> 899,8 +897,6 @@ static irqreturn_t igbvf_intr_msix_rx(int irq, void
> *data)
>  	struct net_device *netdev = data;
>  	struct igbvf_adapter *adapter = netdev_priv(netdev);
> 
> -	adapter->int_counter0++;
> -
>  	/* Write the ITR value calculated at the end of the
>  	 * previous interrupt.
>  	 */
> --
> 2.49.0