netdev - Re: [PATCH net-next 1/9] net: ethtool: copy the rxfh flow handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aEtAds9sHyRsjpgP@MacBook-Air.local>
Date: Fri, 13 Jun 2025 00:02:46 +0300
From: Joe Damato <joe@...a.to>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
	ecree.xilinx@...il.com, andrew@...n.ch
Subject: Re: [PATCH net-next 1/9] net: ethtool: copy the rxfh flow handling

On Wed, Jun 11, 2025 at 07:59:41AM -0700, Jakub Kicinski wrote:
> RX Flow Hash configuration uses the same argument structure
> as flow filters. This is probably why ethtool IOCTL handles
> them together. The more checks we add the more convoluted
> this code is getting (as some of the checks apply only
> to flow filters and others only to the hashing).
> 
> Copy the code to separate the handling. This is an exact
> copy, the next change will remove unnecessary handling.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: andrew@...n.ch
> CC: ecree.xilinx@...il.com
> ---
>  net/ethtool/ioctl.c | 93 ++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 92 insertions(+), 1 deletion(-)
>

Reviewed-by: Joe Damato <joe@...a.to>