netdev - Re: [PATCH net-next 4/4] net: mana: Handle unsupported HWC commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250613101211.GB23310@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
Date: Fri, 13 Jun 2025 03:12:11 -0700
From: Erni Sri Satya Vennela <ernis@...ux.microsoft.com>
To: Dipayaan Roy <dipayanroy@...ux.microsoft.com>
Cc: kys@...rosoft.com, haiyangz@...rosoft.com, wei.liu@...nel.org,
	decui@...rosoft.com, andrew+netdev@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	kotaranov@...rosoft.com, longli@...rosoft.com, horms@...nel.org,
	shirazsaleem@...rosoft.com, leon@...nel.org,
	shradhagupta@...ux.microsoft.com, schakrabarti@...ux.microsoft.com,
	rosenp@...il.com, sdf@...ichev.me, linux-hyperv@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-rdma@...r.kernel.org
Subject: Re: [PATCH net-next 4/4] net: mana: Handle unsupported HWC commands

On Wed, Jun 11, 2025 at 04:35:39AM -0700, Dipayaan Roy wrote:
> On Wed, Jun 11, 2025 at 01:46:16AM -0700, Erni Sri Satya Vennela wrote:
> > If any of the HWC commands are not recognized by the
> > underlying hardware, the hardware returns the response
> > header status of -1. Log the information using
> > netdev_info_once to avoid multiple error logs in dmesg.
> > 
> > Signed-off-by: Erni Sri Satya Vennela <ernis@...ux.microsoft.com>
> > Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com>
> > Reviewed-by: Shradha Gupta <shradhagupta@...ux.microsoft.com>
> > ---
> >  drivers/net/ethernet/microsoft/mana/hw_channel.c |  4 ++++
> >  drivers/net/ethernet/microsoft/mana/mana_en.c    | 11 +++++++++++
> >  2 files changed, 15 insertions(+)
> > 
> > diff --git a/drivers/net/ethernet/microsoft/mana/hw_channel.c b/drivers/net/ethernet/microsoft/mana/hw_channel.c
> > index a8c4d8db75a5..70c3b57b1e75 100644
> > --- a/drivers/net/ethernet/microsoft/mana/hw_channel.c
> > +++ b/drivers/net/ethernet/microsoft/mana/hw_channel.c
> > @@ -890,6 +890,10 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len,
> >  	}
> >  
> >  	if (ctx->status_code && ctx->status_code != GDMA_STATUS_MORE_ENTRIES) {
> > +		if (ctx->status_code == -1) {
> Minor comment: instead of == -1 could use some macro like GDMA_STATUS_CMD_UNSUPPORTED, rest LGTM.
Thankyou Dipayaan.
I'll define this macro and us it for the next version.
> 
> Reviewed-by: Dipayaan Roy <dipayanroy@...ux.microsoft.com>