netdev - Re: [PATCH net-next v2 01/14] net: ipv4: Add a flags argument to iptunnel_xmit(), udp_tunnel_xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250613094858.5dfa435e@kernel.org>
Date: Fri, 13 Jun 2025 09:48:58 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Petr Machata <petrm@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, David Ahern
 <dsahern@...il.com>, <netdev@...r.kernel.org>, Simon Horman
 <horms@...nel.org>, Nikolay Aleksandrov <razor@...ckwall.org>, Ido Schimmel
 <idosch@...dia.com>, <mlxsw@...dia.com>, Antonio Quartulli
 <antonio@...nvpn.net>, Pablo Neira Ayuso <pablo@...filter.org>,
 <osmocom-net-gprs@...ts.osmocom.org>, Andrew Lunn <andrew+netdev@...n.ch>,
 Taehee Yoo <ap420073@...il.com>, "Jason A. Donenfeld" <Jason@...c4.com>,
 <wireguard@...ts.zx2c4.com>, Marcelo Ricardo Leitner
 <marcelo.leitner@...il.com>, <linux-sctp@...r.kernel.org>, Jon Maloy
 <jmaloy@...hat.com>, <tipc-discussion@...ts.sourceforge.net>
Subject: Re: [PATCH net-next v2 01/14] net: ipv4: Add a flags argument to
 iptunnel_xmit(), udp_tunnel_xmit_skb()

On Thu, 12 Jun 2025 22:10:35 +0200 Petr Machata wrote:
>  void udp_tunnel_xmit_skb(struct rtable *rt, struct sock *sk, struct sk_buff *skb,
>  			 __be32 src, __be32 dst, __u8 tos, __u8 ttl,
>  			 __be16 df, __be16 src_port, __be16 dst_port,
> -			 bool xnet, bool nocheck)
> +			 bool xnet, bool nocheck, u16 ipcb_flags)

This is a lot of arguments for a function.
I don't have a great suggestion off the top of my head, but maybe
think more about it?