netdev - RE: [PATCH net] pldmfw: Select CRC32 when PLDMFW is selected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR11MB508949985925739C911F18A7D677A@CO1PR11MB5089.namprd11.prod.outlook.com>
Date: Fri, 13 Jun 2025 18:56:21 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: Simon Horman <horms@...nel.org>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo
 Abeni" <pabeni@...hat.com>
CC: Eric Biggers <ebiggers@...gle.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
Subject: RE: [PATCH net] pldmfw: Select CRC32 when PLDMFW is selected



> -----Original Message-----
> From: Simon Horman <horms@...nel.org>
> Sent: Friday, June 13, 2025 9:46 AM
> To: David S. Miller <davem@...emloft.net>; Eric Dumazet
> <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni
> <pabeni@...hat.com>
> Cc: Keller, Jacob E <jacob.e.keller@...el.com>; Eric Biggers
> <ebiggers@...gle.com>; Simon Horman <horms@...nel.org>;
> netdev@...r.kernel.org
> Subject: [PATCH net] pldmfw: Select CRC32 when PLDMFW is selected
> 
> pldmfw calls crc32 code and depends on it being enabled, else
> there is a link error as follows. So PLDMFW should select CRC32.
> 
>   lib/pldmfw/pldmfw.o: In function `pldmfw_flash_image':
>   pldmfw.c:(.text+0x70f): undefined reference to `crc32_le_base'
> 
> This problem was introduced by commit b8265621f488 ("Add pldmfw library
> for PLDM firmware update").
> 
> It manifests as of commit d69ea414c9b4 ("ice: implement device flash
> update via devlink").
> 
> And is more likely to occur as of commit 9ad19171b6d6 ("lib/crc: remove
> unnecessary prompt for CONFIG_CRC32 and drop 'default y'").
> 
> Found by chance while exercising builds based on tinyconfig.
> 
> Fixes: b8265621f488 ("Add pldmfw library for PLDM firmware update")
> Signed-off-by: Simon Horman <horms@...nel.org>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

Thanks!

>  lib/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/Kconfig b/lib/Kconfig
> index 6c1b8f184267..37db228f70a9 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -716,6 +716,7 @@ config GENERIC_LIB_DEVMEM_IS_ALLOWED
> 
>  config PLDMFW
>  	bool
> +	select CRC32
>  	default n
> 
>  config ASN1_ENCODER