netdev - Re: [PATCH V2] net: usb: Convert tasklet API to new bottom half workqueue mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250612185131.2dc7218a@kernel.org>
Date: Thu, 12 Jun 2025 18:51:31 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jun Miao <jun.miao@...el.com>
Cc: oneukum@...e.com, sbhatta@...vell.com, netdev@...r.kernel.org,
 linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] net: usb: Convert tasklet API to new bottom half
 workqueue mechanism

On Tue, 10 Jun 2025 22:54:03 +0800 Jun Miao wrote:
> -			if (rx_alloc_submit(dev, GFP_ATOMIC) == -ENOLINK)
> +			if (rx_alloc_submit(dev, GFP_NOIO) == -ENOLINK)

Sorry, I think Subbaraya mislead you. v1 was fine.
If we want to change the flags (which Im not sure is correct) it should
be a separate commit. Could you repost v1? There is no need to attribute
reviewers with Suggested-by tags. They can send their review tags if
they so wish.
-- 
pw-bot: cr