netdev - Re: [PATCH v4 07/14] tools: ynl_gen_rst.py: move index.rst generator to the script

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250614173526.2fe415e7@foz.lan>
Date: Sat, 14 Jun 2025 17:35:26 +0200
From: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
To: Donald Hunter <donald.hunter@...il.com>, Jonathan Corbet
 <corbet@....net>
Cc: Linux Doc Mailing List <linux-doc@...r.kernel.org>, Akira Yokosawa
 <akiyks@...il.com>, Breno Leitao <leitao@...ian.org>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Ignacio Encinas
 Rubio <ignacio@...cinas.com>, Jan Stancek <jstancek@...hat.com>, Marco
 Elver <elver@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Ruben Wauters
 <rubenru09@....com>, Shuah Khan <skhan@...uxfoundation.org>,
 joel@...lfernandes.org, linux-kernel-mentees@...ts.linux.dev,
 linux-kernel@...r.kernel.org, lkmm@...ts.linux.dev, netdev@...r.kernel.org,
 peterz@...radead.org, stern@...land.harvard.edu
Subject: Re: [PATCH v4 07/14] tools: ynl_gen_rst.py: move index.rst
 generator to the script

Em Sat, 14 Jun 2025 15:15:25 +0100
Donald Hunter <donald.hunter@...il.com> escreveu:

> On Sat, 14 Jun 2025 at 09:56, Mauro Carvalho Chehab
> <mchehab+huawei@...nel.org> wrote:
> >
> > The index.rst generator doesn't really belong to the parsing
> > function. Move it to the command line tool, as it won't be
> > used elsewhere.
> >
> > While here, make it more generic, allowing it to handle either
> > .yaml or .rst as input files.  
> 
> I think this patch can be dropped from the series, if instead you
> remove the index generation code before refactoring into a library.

Works for me. I'll wait for you and Jon's comments with regards to the
location before sending a new version.

Regards,
Mauro

> 
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> > ---
> >  scripts/lib/netlink_yml_parser.py  | 101 ++++++++---------------------
> >  tools/net/ynl/pyynl/ynl_gen_rst.py |  28 +++++++-  

Thanks,
Mauro