netdev - Re: [net-next PATCH v2 5/6] fbnic: Add support for reporting link config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0f564fe-9d0a-4ebb-937c-e2256f8929bb@lunn.ch>
Date: Sun, 15 Jun 2025 00:27:22 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Alexander Duyck <alexander.duyck@...il.com>
Cc: netdev@...r.kernel.org, linux@...linux.org.uk, hkallweit1@...il.com,
	andrew+netdev@...n.ch, davem@...emloft.net, pabeni@...hat.com,
	kuba@...nel.org, kernel-team@...a.com, edumazet@...gle.com
Subject: Re: [net-next PATCH v2 5/6] fbnic: Add support for reporting link
 config

> +static void
> +fbnic_phylink_set_supported_fec_modes(unsigned long *supported)
> +{

I know naming is hard, but can this be called
fbnic_phylink_get_supported_fec_modes() because ...

> +int fbnic_phylink_ethtool_ksettings_get(struct net_device *netdev,
> +					struct ethtool_link_ksettings *cmd)
> +{
> +	struct fbnic_net *fbn = netdev_priv(netdev);
> +	int err;
> +
> +	err = phylink_ethtool_ksettings_get(fbn->phylink, cmd);
> +	if (!err) {
> +		unsigned long *supp = cmd->link_modes.supported;
> +
> +		cmd->base.port = PORT_DA;
> +		cmd->lanes = (fbn->aui & FBNIC_AUI_MODE_R2) ? 2 : 1;
> +
> +		fbnic_phylink_set_supported_fec_modes(supp);

... calling a _set_ function in ksettings_get() looks odd.

    Andrew

---
pw-bot: cr