netdev - Re: [PATCH 2/2] vhost: vringh: Remove unused functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250616131548.GB4750@horms.kernel.org>
Date: Mon, 16 Jun 2025 14:15:48 +0100
From: Simon Horman <horms@...nel.org>
To: linux@...blig.org
Cc: mst@...hat.com, jasowang@...hat.com, eperezma@...hat.com,
	xuanzhuo@...ux.alibaba.com, kvm@...r.kernel.org,
	virtualization@...ts.linux.dev, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] vhost: vringh: Remove unused functions

On Sat, Jun 14, 2025 at 12:07:31AM +0100, linux@...blig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> The functions:
>   vringh_abandon_kern()
>   vringh_abandon_user()
>   vringh_iov_pull_kern() and
>   vringh_iov_push_kern()
> were all added in 2013 by
> commit f87d0fbb5798 ("vringh: host-side implementation of virtio rings.")
> but have remained unused.
> 
> Remove them.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>

Hi David,

With this patch (set) applied vlang flags the following.
So I guess that xfer_kern can be removed too.

  .../vringh.c:887:19: warning: unused function 'xfer_kern' [-Wunused-function]
    887 | static inline int xfer_kern(const struct vringh *vrh, void *src,
        |                   ^~~~~~~~~
  .../vringh.c:894:19: warning: unused function 'kern_xfer' [-Wunused-function]
    894 | static inline int kern_xfer(const struct vringh *vrh, void *dst,
        |                   ^~~~~~~~~

Otherwise this looks good to me.