netdev - Re: [PATCH net-next v7] Add support to set napi threaded for individual napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAywjhQWG2t31MrBiy95OT4ZpMCteWCG51Uwf1G1si5z1TMRqw@mail.gmail.com>
Date: Sun, 15 Jun 2025 20:51:08 -0700
From: Samiullah Khawaja <skhawaja@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Paolo Abeni <pabeni@...hat.com>, almasrymina@...gle.com, willemb@...gle.com, 
	jdamato@...tly.com, mkarsten@...terloo.ca, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v7] Add support to set napi threaded for
 individual napi

On Sat, Jun 14, 2025 at 1:10 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Fri, 13 Jun 2025 19:16:46 +0000 Samiullah Khawaja wrote:
> > +/**
> > + * napi_get_threaded - get the napi threaded state
> > + * @n: napi struct to get the threaded state from
> > + *
> > + * Return: the per-NAPI threaded state.
> > + */
> > +static inline bool napi_get_threaded(struct napi_struct *n)
> > +{
> > +     return test_bit(NAPI_STATE_THREADED, &n->state);
> > +}
> > +
> > +/**
> > + * napi_set_threaded - set napi threaded state
> > + * @n: napi struct to set the threaded state on
> > + * @threaded: whether this napi does threaded polling
> > + *
> > + * Return 0 on success and negative errno on failure.
> > + */
> > +int napi_set_threaded(struct napi_struct *n, bool threaded);
>
> nit: missing : after Return
+1 will send an update.
>
> but really, I don't think we need kdoc for functions this obvious and
> trivial.
> --
> pw-bot: cr