netdev - Re: [PATCH 1/2] gve: Fix various typos and improve code comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFA9J6-6Kj3LcQL8@MacBook-Air.local>
Date: Mon, 16 Jun 2025 18:49:59 +0300
From: Joe Damato <joe@...a.to>
To: Alok Tiwari <alok.a.tiwari@...cle.com>
Cc: pabeni@...hat.com, kuba@...nel.org, jeroendb@...gle.com,
	hramamurthy@...gle.com, andrew+netdev@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, netdev@...r.kernel.org, almasrymina@...gle.com,
	bcf@...gle.com, linux-kernel@...r.kernel.org, ziweixiao@...gle.com,
	joshwash@...gle.com, willemb@...gle.com, pkaligineedi@...gle.com
Subject: Re: [PATCH 1/2] gve: Fix various typos and improve code comments

On Sun, Jun 15, 2025 at 10:45:00PM -0700, Alok Tiwari wrote:
> - Correct spelling and improves the clarity of comments
>    "confiugration" -> "configuration"
>    "spilt" -> "split"
>    "It if is 0" -> "If it is 0"
>    "DQ" -> "DQO" (correct abbreviation)
> - Clarify BIT(0) flag usage in gve_get_priv_flags()
> - Replaced hardcoded array size with GVE_NUM_PTYPES
>   for clarity and maintainability.

Subject line should target the tree ("net-next") and it's helpful to include
the base-commit (git format-patch --base=auto). Since this series is two
patches you should probably include a short cover letter.

That said, the changes seem reasonable so when you resubmit you can add my:

Reviewed-by: Joe Damato <joe@...a.to>