netdev - Re: [PATCH v3] net: sfp: add quirk for Potron SFP+ XGSPON ONU Stick

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SN6PR1901MB46543B8C0721160E8B3C42FBA570A@SN6PR1901MB4654.namprd19.prod.outlook.com>
Date: Mon, 16 Jun 2025 11:21:59 -0500
From: Chris Morgan <macromorgan@...mail.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Chris Morgan <macroalpha82@...il.com>, netdev@...r.kernel.org,
	andrew@...n.ch, hkallweit1@...il.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Subject: Re: [PATCH v3] net: sfp: add quirk for Potron SFP+ XGSPON ONU Stick

On Mon, Jun 16, 2025 at 10:38:29AM +0100, Russell King (Oracle) wrote:
> On Fri, Jun 13, 2025 at 12:10:02PM -0500, Chris Morgan wrote:
> > @@ -409,7 +414,19 @@ static void sfp_fixup_halny_gsfp(struct sfp *sfp)
> >  	 * these are possibly used for other purposes on this
> >  	 * module, e.g. a serial port.
> >  	 */
> > -	sfp->state_hw_mask &= ~(SFP_F_TX_FAULT | SFP_F_LOS);
> > +	sfp_fixup_ignore_hw(sfp, (SFP_F_TX_FAULT | SFP_F_LOS));
> > +}
> > +
> > +static void sfp_fixup_potron(struct sfp *sfp)
> > +{
> > +	/*
> > +	 * The TX_FAULT and LOS pins on this device are used for serial
> > +	 * communication, so ignore them. Additionally, provide extra
> > +	 * time for this device to fully start up.
> > +	 */
> > +
> > +	sfp_fixup_long_startup(sfp);
> > +	sfp_fixup_ignore_hw(sfp, (SFP_F_TX_FAULT | SFP_F_LOS));
> 
> There's no need for parens around the second argument to
> sfp_fixup_ignore_hw() - the bitwise OR is unambiguous.
> 
> Apart from that, the patch looks fine, thanks.

Thank you, I'll resubmit tomorrow with the requested changes.

- Chris

> 
> -- 
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!