[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250616105259.2f09ce96@kernel.org>
Date: Mon, 16 Jun 2025 10:52:59 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Matthieu Baerts <matttbe@...nel.org>
Cc: Petr Machata <petrm@...dia.com>, "David S. Miller"
<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
<pabeni@...hat.com>, David Ahern <dsahern@...il.com>,
netdev@...r.kernel.org, Simon Horman <horms@...nel.org>, Nikolay
Aleksandrov <razor@...ckwall.org>, Ido Schimmel <idosch@...dia.com>,
mlxsw@...dia.com, Shuah Khan <shuah@...nel.org>,
linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next v2 14/14] selftests: forwarding: Add a test for
verifying VXLAN MC underlay
On Mon, 16 Jun 2025 18:18:18 +0200 Matthieu Baerts wrote:
> > The ALL_TESTS issue is not the end of it either. We use helpers that
> > call stuff indirectly all over the place. defer, in_ns... It would make
> > sense to me to just disable SC2317 in NIPA runs. Or maybe even put it in
> > net/forwarding/.shellcheckrc. Pretty much all those tests are written in
> > a style that will hit these issues.
>
> In this case, I think it would be better to add this .shellcheckrc file
> in net/forwarding. If you modify NIPA, I don't think people will know
> what is allowed or not, or what command line to use, no?
Let's do both? I disabled it to NIPA over the weekend.
Powered by blists - more mailing lists