netdev - RE: [PATCH net-next v2 0/7] eth: intel: migrate to new RXFH callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR11MB50898761E6EE25D237C2227BD670A@CO1PR11MB5089.namprd11.prod.outlook.com>
Date: Mon, 16 Jun 2025 18:25:31 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, "davem@...emloft.net"
	<davem@...emloft.net>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "horms@...nel.org"
	<horms@...nel.org>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "michal.swiatkowski@...ux.intel.com"
	<michal.swiatkowski@...ux.intel.com>, "joe@...a.to" <joe@...a.to>
Subject: RE: [PATCH net-next v2 0/7] eth: intel: migrate to new RXFH callbacks



> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Saturday, June 14, 2025 11:09 AM
> To: davem@...emloft.net
> Cc: netdev@...r.kernel.org; edumazet@...gle.com; pabeni@...hat.com;
> andrew+netdev@...n.ch; horms@...nel.org; intel-wired-lan@...ts.osuosl.org;
> Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; Keller, Jacob E <jacob.e.keller@...el.com>;
> michal.swiatkowski@...ux.intel.com; joe@...a.to; Jakub Kicinski
> <kuba@...nel.org>
> Subject: [PATCH net-next v2 0/7] eth: intel: migrate to new RXFH callbacks
> 
> Migrate Intel drivers to the recently added dedicated .get_rxfh_fields
> and .set_rxfh_fields ethtool callbacks.
> 
> Note that I'm deleting all the boilerplate kdoc from the affected
> functions in the more recent drivers. If the maintainers feel strongly
> I can respin and add it back, but it really feels useless and undue
> burden for refactoring. No other vendor does this.
> 
> v2:
>  - fix missing change to ops struct in ixgbe
> v1: https://lore.kernel.org/20250613010111.3548291-1-kuba@kernel.org
> 
> Jakub Kicinski (7):
>   eth: igb: migrate to new RXFH callbacks
>   eth: igc: migrate to new RXFH callbacks
>   eth: ixgbe: migrate to new RXFH callbacks
>   eth: fm10k: migrate to new RXFH callbacks
>   eth: i40e: migrate to new RXFH callbacks
>   eth: ice: migrate to new RXFH callbacks
>   eth: iavf: migrate to new RXFH callbacks
> 

The whole series looks fine to me, thanks for doing this cleanup!

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

>  .../net/ethernet/intel/fm10k/fm10k_ethtool.c  | 34 ++++-------
>  .../net/ethernet/intel/i40e/i40e_ethtool.c    | 38 +++++-------
>  .../net/ethernet/intel/iavf/iavf_ethtool.c    | 52 ++++------------
>  drivers/net/ethernet/intel/ice/ice_ethtool.c  | 59 ++++++-------------
>  drivers/net/ethernet/intel/igb/igb_ethtool.c  | 20 +++----
>  drivers/net/ethernet/intel/igc/igc_ethtool.c  | 18 +++---
>  .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c  | 22 +++----
>  7 files changed, 85 insertions(+), 158 deletions(-)
> 
> --
> 2.49.0