netdev - [REGRESSION] ixgbe broken after devlink support patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <LV3PR12MB92658474624CCF60220157199470A@LV3PR12MB9265.namprd12.prod.outlook.com>
Date: Mon, 16 Jun 2025 19:42:23 +0000
From: "Kaplan, David" <David.Kaplan@....com>
To: "jedrzej.jagielski@...el.com" <jedrzej.jagielski@...el.com>
CC: "anthony.l.nguyen@...el.com" <anthony.l.nguyen@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"przemyslaw.kitszel@...el.com" <przemyslaw.kitszel@...el.com>,
	"horms@...nel.org" <horms@...nel.org>, Jedrzej Jagielski
	<jedrzej.jagielski@...el.com>, Mateusz Polchlopek
	<mateusz.polchlopek@...el.com>, Bharath R <bharath.r@...el.com>,
	"regressions@...ts.linux.dev" <regressions@...ts.linux.dev>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
Subject: [REGRESSION] ixgbe broken after devlink support patch

[AMD Official Use Only - AMD Internal Distribution Only]

Hi,

My "Ethernet controller: Intel Corporation Ethernet Controller 10G X550T (rev 01)" device stopped working on recent kernel builds (fails to show up in 'ifconfig' or to get an IP address).  I bisected the failure down to the following commit:

commit a0285236ab93fdfdd1008afaa04561d142d6c276 (HEAD, refs/bisect/bad)
Author: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
Date:   Thu Apr 10 14:59:56 2025 +0200

    ixgbe: add initial devlink support

    Add an initial support for devlink interface to ixgbe driver.

    Similarly to i40e driver the implementation doesn't enable
    devlink to manage device-wide configuration. Devlink instance
    is created for each physical function of PCIe device.

    Create separate directory for devlink related ixgbe files
    and use naming scheme similar to the one used in the ice driver.

    Add a stub for Documentation, to be extended by further patches.

    Change struct ixgbe_adapter allocation to be done by devlink (Przemek),
    as suggested by Jiri.

    Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
    Co-developed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
    Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
    Tested-by: Bharath R <bharath.r@...el.com>
    Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
    Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>

Normally, the device is given a name like enp194s0f0 and connects to the wired network.  Starting with this patch, it fails to do so.  I'm not familiar with how to debug this particular device, so please let me know what other information would be of assistance.

lspci -vv information (on a working build):

c2:00.0 Ethernet controller: Intel Corporation Ethernet Controller 10G X550T (rev 01)
        Subsystem: ASRock Incorporation Ethernet Controller 10G X550T
        Physical Slot: 0-1
        Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+
        Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
        Latency: 0
        Interrupt: pin A routed to IRQ 77
        IOMMU group: 12
        Region 0: Memory at 18020800000 (64-bit, prefetchable) [size=4M]
        Region 4: Memory at 18020c04000 (64-bit, prefetchable) [size=16K]
        Expansion ROM at b6000000 [disabled] [size=512K]
        Capabilities: <access denied>
        Kernel driver in use: ixgbe
        Kernel modules: ixgbe

Thanks --David Kaplan