netdev - Re: [PATCH net] net/mlx4e: Remove redundant definition of IB_MTU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250616200427.GC5000@horms.kernel.org>
Date: Mon, 16 Jun 2025 21:04:27 +0100
From: Simon Horman <horms@...nel.org>
To: Leon Romanovsky <leon@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Mark Zhang <markzhang@...dia.com>,
	linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
	Paolo Abeni <pabeni@...hat.com>,
	Patrisious Haddad <phaddad@...dia.com>,
	Tariq Toukan <tariqt@...dia.com>, Jason Gunthorpe <jgg@...dia.com>
Subject: Re: [PATCH net] net/mlx4e: Remove redundant definition of IB_MTU_XXX

On Mon, Jun 16, 2025 at 09:33:05PM +0300, Leon Romanovsky wrote:
> On Mon, Jun 16, 2025 at 05:36:02PM +0100, Simon Horman wrote:
> > On Mon, Jun 16, 2025 at 11:24:23AM +0300, Leon Romanovsky wrote:
> > > From: Mark Zhang <markzhang@...dia.com>
> > > 
> > > Remove them to avoid "redeclaration of enumerator" build error, as they
> > > are already defined in ib_verbs.h. This is needed for the following
> > > patch, which need to include the ib_verbs.h.
> > > 
> > > Fixes: 096335b3f983 ("mlx4_core: Allow dynamic MTU configuration for IB ports")
> > > Reviewed-by: Patrisious Haddad <phaddad@...dia.com>
> > > Signed-off-by: Mark Zhang <markzhang@...dia.com>
> > > Signed-off-by: Leon Romanovsky <leonro@...dia.com>
> > 
> > Hi Mark, Leon, all,
> > 
> > If I understand things correctly, without this patch the driver
> > compiles and functions correctly. But if it is modified to
> > include rdma/ib_verbs.h, which is required for some other forthcoming
> > change, then the other parts of this patch are needed to avoid a build
> > failure.
> 
> Yes, the inclusion of rdma/ib_verbs.h was needed for series, which at
> the end doesn't need it. I can drop Fixes line if it is important.
> 
> There is no following patches for this. It is standalone change.

Sure, that is fine by me.
But please drop the Fixes tag and resubmit for net-next.

Thanks