netdev - Re: [PATCH net] net: ftgmac100: select FIXED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <da7f896f-2636-40c1-a8ab-bf4e55b6d726@gmail.com>
Date: Mon, 16 Jun 2025 23:28:36 +0200
From: Heiner Kallweit <hkallweit1@...il.com>
To: Andrew Lunn <andrew+netdev@...n.ch>, Paolo Abeni <pabeni@...hat.com>,
 Jakub Kicinski <kuba@...nel.org>, David Miller <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Simon Horman <horms@...nel.org>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net] net: ftgmac100: select FIXED_PHY

On 16.06.2025 22:27, Heiner Kallweit wrote:
> Depending on e.g. DT configuration this driver uses a fixed link.
> So we shouldn't rely on the user to enable FIXED_PHY, select it in
> Kconfig instead. We may end up with a non-functional driver otherwise.
> 
> Fixes: 38561ded50d0 ("net: ftgmac100: support fixed link")
> Cc: stable@...r.kernel.org
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
>  drivers/net/ethernet/faraday/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/faraday/Kconfig b/drivers/net/ethernet/faraday/Kconfig
> index c699bd6bc..474073c7f 100644
> --- a/drivers/net/ethernet/faraday/Kconfig
> +++ b/drivers/net/ethernet/faraday/Kconfig
> @@ -31,6 +31,7 @@ config FTGMAC100
>  	depends on ARM || COMPILE_TEST
>  	depends on !64BIT || BROKEN
>  	select PHYLIB
> +	select FIXED_PHY
>  	select MDIO_ASPEED if MACH_ASPEED_G6
>  	select CRC32
>  	help

Two blamed authors missing, will resubmit.
---
pw-bot: cr