netdev - Re: [PATCH net v1 3/4] selftests: net: add test for passive TFO socket NAPI ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9684c5ec-3d52-44b6-89f6-e7ae606fe51b@davidwei.uk>
Date: Mon, 16 Jun 2025 17:02:37 -0700
From: David Wei <dw@...idwei.uk>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
 Neal Cardwell <ncardwell@...gle.com>, Kuniyuki Iwashima <kuniyu@...gle.com>,
 "David S. Miller" <davem@...emloft.net>, David Ahern <dsahern@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 Andrew Lunn <andrew+netdev@...n.ch>, Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH net v1 3/4] selftests: net: add test for passive TFO
 socket NAPI ID

On 2025-06-16 13:13, Jakub Kicinski wrote:
> On Mon, 16 Jun 2025 11:54:55 -0700 David Wei wrote:
>> Add a test that checks that the NAPI ID of a passive TFO socket is valid
>> i.e. not zero.
> 
> Could you run shellcheck and make sure none of the warnings are legit?

The single shellcheck warning I get is this:

In tools/testing/selftests/net/tfo_passive.sh line 76:
if [ $? -ne 0 ]; then
      ^-- SC2320 (warning): This $? refers to echo/printf, not a previous command. Assign to variable to avoid it being overwritten.

I confirmed that if writing to the sysfs file returns an error e.g.
EINVAL then echo returns a non-zero status. The existing peer.sh and
busy_poll_test.sh does the same check.