netdev - Re: [net-next v6 1/4] net: bonding: add broadcast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DC8E2D25-3CEB-4E45-965E-D6A3D2DD4B3D@bamaicloud.com>
Date: Tue, 17 Jun 2025 18:25:47 +0800
From: Tonghao Zhang <tonghao@...aicloud.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org,
 Jay Vosburgh <jv@...sburgh.net>,
 "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>,
 Jonathan Corbet <corbet@....net>,
 Andrew Lunn <andrew+netdev@...n.ch>,
 Steven Rostedt <rostedt@...dmis.org>,
 Masami Hiramatsu <mhiramat@...nel.org>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Nikolay Aleksandrov <razor@...ckwall.org>,
 Zengbing Tu <tuzengbing@...iglobal.com>
Subject: Re: [net-next v6 1/4] net: bonding: add broadcast_neighbor option for
 802.3ad

> 2025年6月17日 07:04，Jakub Kicinski <kuba@...nel.org> 写道：
> 
> On Tue, 10 Jun 2025 11:44:42 +0800 Tonghao Zhang wrote:
>> + if (bond->params.broadcast_neighbor)
>> + static_branch_inc(&bond_bcast_neigh_enabled);
>> }
>> 
>> if (bond_mode_can_use_xmit_hash(bond))
>> @@ -4475,6 +4480,10 @@ static int bond_close(struct net_device *bond_dev)
>> bond_alb_deinitialize(bond);
>> bond->recv_probe = NULL;
>> 
>> + if (BOND_MODE(bond) == BOND_MODE_8023AD &&
>> +    bond->params.broadcast_neighbor)
>> + static_branch_dec(&bond_bcast_neigh_enabled);
> 
> is .broadcast_neighbor automatically cleared when mode is changed?
> I don't see it in the code.
No clean this value when changing the mode, this option don’t work in other mode.  But it is better to clean up it.
> -- 
> pw-bot: cr
> 
>