netdev - Re: [ovs-dev] [PATCH net] openvswitch: Allocate struct ovs_pcpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7tqzzipptp.fsf@redhat.com>
Date: Tue, 17 Jun 2025 07:31:14 -0400
From: Aaron Conole <aconole@...hat.com>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc: netdev@...r.kernel.org,  dev@...nvswitch.org,  Ilya Maximets
 <i.maximets@....org>,  "David S. Miller" <davem@...emloft.net>,  Eric
 Dumazet <edumazet@...gle.com>,  Simon Horman <horms@...nel.org>,  Jakub
 Kicinski <kuba@...nel.org>,  Paolo Abeni <pabeni@...hat.com>,  Gal
 Pressman <gal@...dia.com>
Subject: Re: [ovs-dev] [PATCH net] openvswitch: Allocate struct
 ovs_pcpu_storage dynamically

Sebastian Andrzej Siewior <bigeasy@...utronix.de> writes:

> PERCPU_MODULE_RESERVE defines the maximum size that can by used for the
> per-CPU data size used by modules. This is 8KiB.
>
> Commit 035fcdc4d240c ("openvswitch: Merge three per-CPU structures into
> one") restructured the per-CPU memory allocation for the module and
> moved the separate alloc_percpu() invocations at module init time to a
> static per-CPU variable which is allocated by the module loader.
>
> The size of the per-CPU data section for openvswitch is 6488 bytes which
> is ~80% of the available per-CPU memory. Together with a few other
> modules it is easy to exhaust the available 8KiB of memory.
>
> Allocate ovs_pcpu_storage dynamically at module init time.
>
> Reported-by: Gal Pressman <gal@...dia.com>
> Closes:
> https://lore.kernel.org/all/c401e017-f8db-4f57-a1cd-89beb979a277@nvidia.com
> Fixes: 035fcdc4d240c ("openvswitch: Merge three per-CPU structures into one")
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> ---
>
> Gal, would you please be so kind and check if this works for you?
>

I was hoping Gal would have gotten back by now.

Reviewed-by: Aaron Conole <aconole@...hat.com>