netdev - Re: [PATCH net-next v3 03/10] net: fec: add missing header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250617-funky-auspicious-stallion-25f396-mkl@pengutronix.de>
Date: Tue, 17 Jun 2025 17:07:40 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Alexander Lobakin <aleksander.lobakin@...el.com>
Cc: Wei Fang <wei.fang@....com>, Shenwei Wang <shenwei.wang@....com>, 
	Clark Wang <xiaoning.wang@....com>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Richard Cochran <richardcochran@...il.com>, 
	Andrew Lunn <andrew+netdev@...n.ch>, imx@...ts.linux.dev, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, kernel@...gutronix.de, Frank Li <Frank.Li@....com>, 
	Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net-next v3 03/10] net: fec: add missing header files

On 17.06.2025 16:55:19, Alexander Lobakin wrote:
> From: Marc Kleine-Budde <mkl@...gutronix.de>
> Date: Tue, 17 Jun 2025 15:24:53 +0200
> 
> > The fec.h isn't self contained. Add missing header files, so that it can be
> > parsed by language servers without errors.
> > 
> > Reviewed-by: Wei Fang <wei.fang@....com>
> > Reviewed-by: Frank Li <Frank.Li@....com>
> > Reviewed-by: Andrew Lunn <andrew@...n.ch>
> > Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>
> > ---
> >  drivers/net/ethernet/freescale/fec.h | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/net/ethernet/freescale/fec.h b/drivers/net/ethernet/freescale/fec.h
> > index ce1e4fe4d492..4098d439a6ff 100644
> > --- a/drivers/net/ethernet/freescale/fec.h
> > +++ b/drivers/net/ethernet/freescale/fec.h
> > @@ -15,7 +15,9 @@
> >  /****************************************************************************/
> >  
> >  #include <linux/clocksource.h>
> > +#include <linux/ethtool.h>
> >  #include <linux/net_tstamp.h>
> > +#include <linux/phy.h>
> >  #include <linux/pm_qos.h>
> >  #include <linux/bpf.h>
> >  #include <linux/ptp_clock_kernel.h>
> 
> Sort alphabetically while at it? You'd only need to move bpf.h AFAICS.

After sorting, the incremental diff will look like this:

diff --git a/drivers/net/ethernet/freescale/fec.h b/drivers/net/ethernet/freescale/fec.h
index 15334a5cce0f..1fe5e92afeb3 100644
--- a/drivers/net/ethernet/freescale/fec.h
+++ b/drivers/net/ethernet/freescale/fec.h
@@ -14,16 +14,16 @@
 #define FEC_H
 /****************************************************************************/
 
+#include <dt-bindings/firmware/imx/rsrc.h>
+#include <linux/bpf.h>
 #include <linux/clocksource.h>
 #include <linux/ethtool.h>
+#include <linux/firmware/imx/sci.h>
 #include <linux/net_tstamp.h>
 #include <linux/phy.h>
 #include <linux/pm_qos.h>
-#include <linux/bpf.h>
 #include <linux/ptp_clock_kernel.h>
 #include <linux/timecounter.h>
-#include <dt-bindings/firmware/imx/rsrc.h>
-#include <linux/firmware/imx/sci.h>
 #include <net/xdp.h>
 
 #if defined(CONFIG_M523x) || defined(CONFIG_M527x) || defined(CONFIG_M528x) || \

Is that okay? If so, I'll squash it.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)