netdev - Re: [PATCH v2 3/3] arm64: dts: renesas: rzg3e-smarc-som: Enable eth{0-1} (GBETH) interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWJNCSUj6mUweKtXycHNNok4L=TFQipVO8n9g7DiU=b9A@mail.gmail.com>
Date: Tue, 17 Jun 2025 17:50:50 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: John Madieu <john.madieu.xa@...renesas.com>
Cc: andrew+netdev@...n.ch, conor+dt@...nel.org, davem@...emloft.net, 
	edumazet@...gle.com, krzk+dt@...nel.org, kuba@...nel.org, pabeni@...hat.com, 
	prabhakar.mahadev-lad.rj@...renesas.com, robh@...nel.org, 
	biju.das.jz@...renesas.com, devicetree@...r.kernel.org, john.madieu@...il.com, 
	linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org, 
	magnus.damm@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 3/3] arm64: dts: renesas: rzg3e-smarc-som: Enable
 eth{0-1} (GBETH) interfaces

Hi John,

On Wed, 11 Jun 2025 at 11:00, John Madieu <john.madieu.xa@...renesas.com> wrote:
> Enable the Gigabit Ethernet Interfaces (GBETH) populated on the RZ/G3E SMARC EVK
>
> Reviewed-by: Biju Das <biju.das.jz@...renesas.com>
> Tested-by: Biju Das <biju.das.jz@...renesas.com>
> Signed-off-by: John Madieu <john.madieu.xa@...renesas.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi

> @@ -77,6 +79,74 @@ &audio_extal_clk {
>         clock-frequency = <48000000>;
>  };
>
> +&eth0 {
> +       phy-handle = <&phy0>;
> +       phy-mode = "rgmii-id";
> +
> +       pinctrl-0 = <&eth0_pins>;
> +       pinctrl-names = "default";
> +       status = "okay";
> +
> +       mdio {

&mdio0 {

> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               compatible = "snps,dwmac-mdio";

No need for these three properties, as they are already present in the
SoC-specific DTS with the exact same values.

Same for the second interface.

The rest LGTM, so with the above fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds