netdev - Re: [PATCH net-next v3 2/4] bonding: Extend arp_ip_target format to allow for a list of vlan tags.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1969718.1750176393@famine>
Date: Tue, 17 Jun 2025 09:06:33 -0700
From: Jay Vosburgh <jv@...sburgh.net>
To: David Wilder <wilder@...ibm.com>
cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
    "pradeeps@...ux.vnet.ibm.com" <pradeeps@...ux.vnet.ibm.com>,
    Pradeep Satyanarayana <pradeep@...ibm.com>,
    "i.maximets@....org" <i.maximets@....org>,
    Adrian Moreno Zapata <amorenoz@...hat.com>,
    Hangbin Liu <haliu@...hat.com>
Subject: Re: [PATCH net-next v3 2/4] bonding: Extend arp_ip_target format to
 allow for a list of vlan tags.

David Wilder <wilder@...ibm.com> wrote:

>
>
>>        Here, and further down in bond_arp_ip_target_opt_parse(),
>>there's a lot of string handling that seems out place.  Why isn't the
>>string parsing done in user space (iproute, et al), and the tags passed
>>to the kernel in IFLA_BOND_ARP_IP_TARGET as an optional nested
>>attribute?
>
>>>+              }
>
>>        There is no expectation that sysfs should support new bonding
>>API elements; only netlink / iproute2 support matters.  If sysfs is the
>>reason to do the string parsing in the kernel, then I imagine this could
>>all move into userspace.
>>
>>     -J
>
>Module parameter support also requires string parsing in the kernel. Can that be dropped as well?

	Yes.  New bonding functionality need not be supported by sysfs
or module parameters.

	-J

---
	-Jay Vosburgh, jv@...sburgh.net