netdev - Re: [PATCH v3] net/sched: fix use-after-free in taprio_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250617170359.GA2545@horms.kernel.org>
Date: Tue, 17 Jun 2025 18:03:59 +0100
From: Simon Horman <horms@...nel.org>
To: Hyunwoo Kim <imv4bel@...il.com>
Cc: vinicius.gomes@...el.com, jhs@...atatu.com, xiyou.wangcong@...il.com,
	jiri@...nulli.us, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, vladimir.oltean@....com,
	netdev@...r.kernel.org, v4bel@...ori.io
Subject: Re: [PATCH v3] net/sched: fix use-after-free in taprio_dev_notifier

On Fri, Jun 13, 2025 at 08:54:57PM -0400, Hyunwoo Kim wrote:
> Since taprio’s taprio_dev_notifier() isn’t protected by an
> RCU read-side critical section, a race with advance_sched()
> can lead to a use-after-free.
> 
> Adding rcu_read_lock() inside taprio_dev_notifier() prevents this.
> 
> Fixes: fed87cc6718a ("net/sched: taprio: automatically calculate queueMaxSDU based on TC gate durations")
> Cc: stable@...r.kernel.org
> Signed-off-by: Hyunwoo Kim <imv4bel@...il.com>
> ---
> Changes in v3:
> - Change so that taprio_set_picos_per_byte() is not included in the lock.
> - v2: https://lore.kernel.org/all/aEq3J4ODxH7x+neT@v4bel-B760M-AORUS-ELITE-AX/
> 
> Changes in v2:
> - Add the appropriate tags.
> - v1: https://lore.kernel.org/all/aElUZyKy7x66X3SD@v4bel-B760M-AORUS-ELITE-AX/

Thanks for the update.

I agree that this is consistent with the review by Vladimir of v2.

Reviewed-by: Simon Horman <horms@...nel.org>

...