netdev - RE: [PATCH net v1] mlxbf_gige: return EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MN0PR12MB5907DC095A95A1BA1F2472FDC773A@MN0PR12MB5907.namprd12.prod.outlook.com>
Date: Tue, 17 Jun 2025 20:07:37 +0000
From: David Thompson <davthompson@...dia.com>
To: Simon Horman <horms@...nel.org>
CC: "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"u.kleine-koenig@...libre.com" <u.kleine-koenig@...libre.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Asmaa Mnebhi
	<asmaa@...dia.com>
Subject: RE: [PATCH net v1] mlxbf_gige: return EPROBE_DEFER if PHY IRQ is not
 available

> -----Original Message-----
> From: Simon Horman <horms@...nel.org>
> Sent: Monday, June 16, 2025 8:45 AM
> To: David Thompson <davthompson@...dia.com>
> Cc: andrew+netdev@...n.ch; davem@...emloft.net; edumazet@...gle.com;
> kuba@...nel.org; pabeni@...hat.com; u.kleine-koenig@...libre.com;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Asmaa Mnebhi
> <asmaa@...dia.com>
> Subject: Re: [PATCH net v1] mlxbf_gige: return EPROBE_DEFER if PHY IRQ is not
> available
> 
> On Fri, Jun 13, 2025 at 06:51:29PM +0000, David Thompson wrote:
> > The message "Error getting PHY irq. Use polling instead"
> > is emitted when the mlxbf_gige driver is loaded by the kernel before
> > the associated gpio-mlxbf driver, and thus the call to get the PHY IRQ
> > fails since it is not yet available. The driver probe() must return
> > -EPROBE_DEFER if acpi_dev_gpio_irq_get_by() returns the same.
> >
> > Signed-off-by: David Thompson <davthompson@...dia.com>
> > Reviewed-by: Asmaa Mnebhi <asmaa@...dia.com>
> 
> Thanks David,
> 
> I as a bug fix this needs a Fixes tag, which you can add by simply replying to this
> email.
> 
> Else we can treat it as an enhancement for net-next.

Yes, good point Simon.

This patch is a fix, so should have the following Fixes tag:
	Fixes: 6c2a6ddca763 ("net: mellanox: mlxbf_gige: Replace non-standard interrupt handling")

Regards, Dave