netdev - Re: [PATCH net v1] net: netmem: fix skb_ensure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <175020123275.3727356.1557210847421675241.git-patchwork-notify@kernel.org>
Date: Tue, 17 Jun 2025 23:00:32 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Mina Almasry <almasrymina@...gle.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
 willemb@...gle.com, sdf@...ichev.me, asml.silence@...il.com
Subject: Re: [PATCH net v1] net: netmem: fix skb_ensure_writable with
 unreadable
 skbs

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Sun, 15 Jun 2025 20:07:33 +0000 you wrote:
> skb_ensure_writable should succeed when it's trying to write to the
> header of the unreadable skbs, so it doesn't need an unconditional
> skb_frags_readable check. The preceding pskb_may_pull() call will
> succeed if write_len is within the head and fail if we're trying to
> write to the unreadable payload, so we don't need an additional check.
> 
> Removing this check restores DSCP functionality with unreadable skbs as
> it's called from dscp_tg.
> 
> [...]

Here is the summary with links:
  - [net,v1] net: netmem: fix skb_ensure_writable with unreadable skbs
    https://git.kernel.org/netdev/net/c/6f793a1d0537

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html