netdev - Re: [PATCH net-next v2] net: ti: icssg-prueth: Add prp offload support to ICSSG driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250618102907.GA1699@horms.kernel.org>
Date: Wed, 18 Jun 2025 11:29:07 +0100
From: Simon Horman <horms@...nel.org>
To: Himanshu Mittal <h-mittal1@...com>
Cc: pabeni@...hat.com, kuba@...nel.org, edumazet@...gle.com,
	davem@...emloft.net, andrew+netdev@...n.ch,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, srk@...com,
	Vignesh Raghavendra <vigneshr@...com>,
	Roger Quadros <rogerq@...nel.org>, danishanwar@...com,
	m-malladi@...com, pratheesh@...com, prajith@...com
Subject: Re: [PATCH net-next v2] net: ti: icssg-prueth: Add prp offload
 support to ICSSG driver

On Tue, Jun 17, 2025 at 03:48:37PM +0530, Himanshu Mittal wrote:
> Add support for ICSSG PRP mode which supports offloading of:
>  - Packet duplication and PRP trailer insertion
>  - Packet duplicate discard and PRP trailer removal
> 
> Signed-off-by: Himanshu Mittal <h-mittal1@...com>
> ---
> v2-v1:
> - Align with recent firmware name handling updates made in:
>  https://lore.kernel.org/all/20250613064547.44394-1-danishanwar@ti.com/
> 
> v1: https://lore.kernel.org/all/42ac0736-cb5a-4d99-a11c-6f861adbdb5f@ti.com/

...

> diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.h b/drivers/net/ethernet/ti/icssg/icssg_prueth.h

...

> @@ -349,6 +352,7 @@ struct prueth {
>  	struct icssg_firmwares icssg_emac_firmwares[PRUETH_NUM_MACS];
>  	struct icssg_firmwares icssg_switch_firmwares[PRUETH_NUM_MACS];
>  	struct icssg_firmwares icssg_hsr_firmwares[PRUETH_NUM_MACS];
> +	struct icssg_firmwares icssg_prp_firmwares[PRUETH_NUM_MACS];
>  };

Hi Himanshu,

Please also add icssg_prp_firmwares to the Kernel doc for struct preth,
which appears a little above this hunk.

Flagged by ./scripts/kernel-doc -none

Otherwise, this patch looks good to me.

-- 
pw-bot: changes-requested