netdev - Re: [PATCH net-next v8 4/6] net: usb: lan78xx: port link settings to phylink API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFK4jVTHJmF-ZU-t@shell.armlinux.org.uk>
Date: Wed, 18 Jun 2025 14:01:01 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Woojung Huh <woojung.huh@...rochip.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Thangaraj Samynathan <Thangaraj.S@...rochip.com>,
	Rengarajan Sundararajan <Rengarajan.S@...rochip.com>,
	Maxime Chevallier <maxime.chevallier@...tlin.com>,
	kernel@...gutronix.de, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, UNGLinuxDriver@...rochip.com,
	Phil Elwell <phil@...pberrypi.org>, Simon Horman <horms@...nel.org>
Subject: Re: [PATCH net-next v8 4/6] net: usb: lan78xx: port link settings to
 phylink API

On Wed, Jun 18, 2025 at 02:26:00PM +0200, Oleksij Rempel wrote:
> Refactor lan78xx_get_link_ksettings and lan78xx_set_link_ksettings to
> use the phylink API (phylink_ethtool_ksettings_get and
> phylink_ethtool_ksettings_set) instead of directly interfacing with the
> PHY. This change simplifies the code and ensures better integration with
> the phylink framework for link management.
> 
> Additionally, the explicit calls to usb_autopm_get_interface() and
> usb_autopm_put_interface() have been removed. These were originally
> needed to manage USB power management during register accesses. However,
> lan78xx_mdiobus_read() and lan78xx_mdiobus_write() already handle USB
> auto power management internally, ensuring that the interface remains
> active when necessary. Since there are no other direct register accesses
> in these functions that require explicit power management handling, the
> extra calls have become redundant and are no longer needed.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>

Reviewed-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!