netdev - Re: [PATCH v2 net-next] eth: bnxt: add netmem TX support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLik9ZSytqhq8Z=G=ob01J5nDd32JxKcMKrdnxt5R+-gbAQ@mail.gmail.com>
Date: Wed, 18 Jun 2025 10:20:49 -0700
From: Michael Chan <michael.chan@...adcom.com>
To: Taehee Yoo <ap420073@...il.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, 
	edumazet@...gle.com, andrew+netdev@...n.ch, horms@...nel.org, 
	pavan.chebbi@...adcom.com, almasrymina@...gle.com, praan@...gle.com, 
	shivajikant@...gle.com, asml.silence@...il.com, sdf@...ichev.me, 
	netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] eth: bnxt: add netmem TX support

On Wed, Jun 18, 2025 at 6:54 AM Taehee Yoo <ap420073@...il.com> wrote:
>
> Use netmem_dma_*() helpers and declare netmem_tx to support netmem TX.
> By this change, all bnxt devices will support the netmem TX.
>
> Unreadable skbs are not going to be handled by the TX push logic.
> So, it checks whether a skb is readable or not before the TX push logic.
>
> netmem TX can be tested with ncdevmem.c
>
> Acked-by: Mina Almasry <almasrymina@...gle.com>
> Acked-by: Stanislav Fomichev <sdf@...ichev.me>
> Signed-off-by: Taehee Yoo <ap420073@...il.com>
> ---
>
> v2:
>  - Fix commit message.
>  - Add Ack tags from Mina and Stanislav.
>

Thanks for the patch.  At a quick glance, it seems that the netmem dma
unmap is missing in __bnxt_tx_int().

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4196 bytes)