netdev - Re: Issue with rtnl_lock in wg_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250618114735.5472f2cd@kernel.org>
Date: Wed, 18 Jun 2025 11:47:35 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Sharath Chandra Vurukala <quic_sharathv@...cinc.com>
Cc: <Jason@...c4.com>, <wireguard@...ts.zx2c4.com>, <netdev@...r.kernel.org>
Subject: Re: Issue with rtnl_lock in wg_pm_notification

On Tue, 17 Jun 2025 01:44:56 +0530 Sharath Chandra Vurukala wrote:
> I do not understand fully what wireguard functionality is, but
> considering that rtnl_lock is a global one, it does not seem to be a
> good design to have notification callback acquire this lock.

I'm not very familiar with the PM locks, but isn't the PM notification
lock also a global one? Again, not an expert but having PM lock outside
the rtnl_lock would be more intuitive to me.