netdev - Re: [PATCH net-next 0/2] net: xsk: add two sysctl knobs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL+tcoA67FiFZ_DVO-22vvWEcPjt1UScb_hcTvJhuWsiEYd5EA@mail.gmail.com>
Date: Wed, 18 Jun 2025 08:31:55 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Joe Damato <joe@...a.to>, Stanislav Fomichev <stfomichev@...il.com>, 
	Jason Xing <kerneljasonxing@...il.com>, davem@...emloft.net, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, bjorn@...nel.org, 
	magnus.karlsson@...el.com, maciej.fijalkowski@...el.com, 
	jonathan.lemon@...il.com, sdf@...ichev.me, ast@...nel.org, 
	daniel@...earbox.net, hawk@...nel.org, john.fastabend@...il.com, 
	bpf@...r.kernel.org, netdev@...r.kernel.org, 
	Jason Xing <kernelxing@...cent.com>
Subject: Re: [PATCH net-next 0/2] net: xsk: add two sysctl knobs

On Wed, Jun 18, 2025 at 3:17 AM Joe Damato <joe@...a.to> wrote:
>
> On Tue, Jun 17, 2025 at 10:46:26AM -0700, Stanislav Fomichev wrote:
> > On 06/17, Jason Xing wrote:
>
> > > >
> > > > Also, can we put these settings into the socket instead of (global/ns)
> > > > sysctl?
> > >
> > > As to MAX_PER_SOCKET_BUDGET, it seems not easy to get its
> > > corresponding netns? I have no strong opinion on this point for now.
> >
> > I'm suggesting something along these lines (see below). And then add
> > some way to configure it (plus, obviously, set the default value
> > on init).
>
> +1 from me on making this per-socket instead of global with sysfs.
>
> I feel like the direction networking has taken lately (netdev-genl, for
> example) is to make things more granular instead of global.

Agree. Previously I missed using sock_net(sk)->core->xxx to make it
namespecified :(

Thanks,
Jason