netdev - Re: [PATCH net v1] netmem: fix skb_frag_address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250618145330.2584636e@kernel.org>
Date: Wed, 18 Jun 2025 14:53:30 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Mina Almasry <almasrymina@...gle.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, ap420073@...il.com
Subject: Re: [PATCH net v1] netmem: fix skb_frag_address_safe with
 unreadable skbs

On Tue, 17 Jun 2025 21:09:50 +0000 Mina Almasry wrote:
> +	void *ptr;
> +
> +	if (!skb_frag_page(frag))
> +		return NULL;
> +
> +	ptr = page_address(skb_frag_page(frag));

Sorry, noticed mid-push that we're calling skb_frag_page() twice.
Let's save the return value and pass it to page_address?
-- 
pw-bot: cr