netdev - Re: [PATCH net v2 4/4] tcp: fix passive TFO socket having invalid NAPI ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iLzzgk=kWrR8vE6K5_o3RabRQf9dcCGeFYrwa7Os8MS0g@mail.gmail.com>
Date: Wed, 18 Jun 2025 01:11:04 -0700
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuni1840@...il.com>
Cc: dw@...idwei.uk, andrew+netdev@...n.ch, davem@...emloft.net, 
	dsahern@...nel.org, horms@...nel.org, kuba@...nel.org, ncardwell@...gle.com, 
	netdev@...r.kernel.org, pabeni@...hat.com, shuah@...nel.org, 
	Kuniyuki Iwashima <kuniyu@...gle.com>
Subject: Re: [PATCH net v2 4/4] tcp: fix passive TFO socket having invalid
 NAPI ID

On Tue, Jun 17, 2025 at 2:29 PM Kuniyuki Iwashima <kuni1840@...il.com> wrote:
>
> From: David Wei <dw@...idwei.uk>
> Date: Tue, 17 Jun 2025 14:21:02 -0700
> > There is a bug with passive TFO sockets returning an invalid NAPI ID 0
> > from SO_INCOMING_NAPI_ID. Normally this is not an issue, but zero copy
> > receive relies on a correct NAPI ID to process sockets on the right
> > queue.
> >
> > Fix by adding a sk_mark_napi_id_set().
> >
> > Fixes: e5907459ce7e ("tcp: Record Rx hash and NAPI ID in tcp_child_process")
> > Signed-off-by: David Wei <dw@...idwei.uk>
>
> Reviewed-by: Kuniyuki Iwashima <kuniyu@...gle.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>