netdev - Re: Re: [net-next v5 3/3] net: ethernet: mtk_eth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250619125137.GN1699@horms.kernel.org>
Date: Thu, 19 Jun 2025 13:51:37 +0100
From: Simon Horman <horms@...nel.org>
To: Frank Wunderlich <frank-w@...lic-files.de>
Cc: linux@...web.de, nbd@....name, sean.wang@...iatek.com,
	lorenzo@...nel.org, andrew+netdev@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	matthias.bgg@...il.com, angelogioacchino.delregno@...labora.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org, daniel@...rotopia.org,
	arinc.unal@...nc9.com
Subject: Re: Re: [net-next v5 3/3] net: ethernet: mtk_eth_soc: skip first IRQ
 if not used

On Thu, Jun 19, 2025 at 10:32:05AM +0000, Frank Wunderlich wrote:
> Hi Simon
> 
> > Gesendet: Donnerstag, 19. Juni 2025 um 12:03
> > Von: "Simon Horman" <horms@...nel.org>
> > Betreff: Re: [net-next v5 3/3] net: ethernet: mtk_eth_soc: skip first IRQ if not used
> >
> > On Wed, Jun 18, 2025 at 03:07:14PM +0200, Frank Wunderlich wrote:
> > > From: Frank Wunderlich <frank-w@...lic-files.de>
> > > 
> > > On SoCs without MTK_SHARED_INT capability (all except mt7621 and
> > > mt7628) platform_get_irq() is called for the first IRQ (eth->irq[0])
> > > but it is never used.
> > > Skip the first IRQ and reduce the IRQ-count to 2.
> > > 
> > > Signed-off-by: Frank Wunderlich <frank-w@...lic-files.de>
> > > ---
> > > v5:
> > > - change commit title and description
> > > v4:
> > > - drop >2 condition as max is already 2 and drop the else continue
> > > - update comment to explain which IRQs are taken in legacy way
> > 
> > Reviewed-by: Simon Horman <horms@...nel.org>
> 
> thank you very much
> 
> i guess RB is still valid with changes requested by Daniel?

Yes, thanks for asking.