netdev - Re: [PATCH net] eth: fbnic: avoid double free when failing to DMA-map FW msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250619071004.5e841f1a@kernel.org>
Date: Thu, 19 Jun 2025 07:10:04 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Paolo Abeni <pabeni@...hat.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 andrew+netdev@...n.ch, horms@...nel.org, lee@...ger.us,
 jacob.e.keller@...el.com, Alexander Duyck <alexanderduyck@...com>
Subject: Re: [PATCH net] eth: fbnic: avoid double free when failing to
 DMA-map FW msg

On Thu, 19 Jun 2025 12:18:58 +0200 Paolo Abeni wrote:
> On 6/16/25 9:55 PM, Jakub Kicinski wrote:
> > The semantics are that caller of fbnic_mbx_map_msg() retains
> > the ownership of the message on error.   
> 
> FWIW, I think the opposite semantic would lead to simpler/smaller code
> overall, but no objections to retain the current one.

Interesting, I'd have thought the semantics of "on error caller retains
the ownership of the object they are trying to hand over" are generally
considered more intuitive.