netdev - Re: [PATCH net 1/2] virtio-net: xsk: rx: fix the frame's length check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a38a134-3ce8-4c91-a7e7-2a162cbf3b7c@gmail.com>
Date: Thu, 19 Jun 2025 21:17:03 +0700
From: Bui Quang Minh <minhquangbui99@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, "Michael S. Tsirkin" <mst@...hat.com>,
 Jason Wang <jasowang@...hat.com>, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
 Eugenio Pérez <eperezma@...hat.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Alexei Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>,
 Jesper Dangaard Brouer <hawk@...nel.org>,
 John Fastabend <john.fastabend@...il.com>, virtualization@...ts.linux.dev,
 linux-kernel@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH net 1/2] virtio-net: xsk: rx: fix the frame's length check

On 6/19/25 09:11, Jakub Kicinski wrote:
> On Sun, 15 Jun 2025 22:13:32 +0700 Bui Quang Minh wrote:
>> +/**
>> + * buf_to_xdp() - convert the @buf context to xdp_buff
>> + * @vi: virtnet_info struct
>> + * @rq: the receive queue struct
>> + * @buf: the xdp_buff pointer that is passed to virtqueue_add_inbuf_premapped in
>> + *       virtnet_add_recvbuf_xsk
>> + * @len: the length of received data without virtio header's length
>> + * @first_buf: this buffer is the first one or not
>> + */
>>   static struct xdp_buff *buf_to_xdp(struct virtnet_info *vi,
>> -				   struct receive_queue *rq, void *buf, u32 len)
>> +				   struct receive_queue *rq, void *buf,
>> +				   u32 len, bool first_buf)
> I think Michael mention he's AFK so while we wait could you fix this
> kdoc? I'm not sure whether the kdoc is really necessary here, but if
> you want to keep it you have to document the return value:
>
> Warning: drivers/net/virtio_net.c:1141 No description found for return value of 'buf_to_xdp'

I want to add kdoc to clarify that the @len must be without virtio 
header's length. I'll fix it in the next version.

Thanks,
Quang Minh.