netdev - Re: [PATCH v4 net-next 5/8] net: implement virtio helpers to handle UDP GSO tunneling.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c527a435-dbe4-439c-b55b-7210df3b8dc9@redhat.com>
Date: Thu, 19 Jun 2025 16:59:38 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Jason Wang <jasowang@...hat.com>
Cc: netdev@...r.kernel.org, Willem de Bruijn
 <willemdebruijn.kernel@...il.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, "Michael S. Tsirkin" <mst@...hat.com>,
 Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, Eugenio Pérez
 <eperezma@...hat.com>, Yuri Benditovich <yuri.benditovich@...nix.com>,
 Akihiko Odaki <akihiko.odaki@...nix.com>
Subject: Re: [PATCH v4 net-next 5/8] net: implement virtio helpers to handle
 UDP GSO tunneling.

On 6/18/25 6:08 AM, Jason Wang wrote:
> On Wed, Jun 18, 2025 at 12:13 AM Paolo Abeni <pabeni@...hat.com> wrote:
>> +/*
>> + * vlan_hlen always refers to the outermost MAC header. That also
>> + * means it refers to the only MAC header, if the packet does not carry
>> + * any encapsulation.
>> + */
>> +static inline int
>> +virtio_net_hdr_tnl_from_skb(const struct sk_buff *skb,
>> +                           struct virtio_net_hdr_v1_hash_tunnel *vhdr,
>> +                           bool tnl_hdr_negotiated,
>> +                           bool little_endian,
> 
> Nit: it looks to me we can just accept netdev_features_t here.

That will replace a single bool argument with a netdev_features_t, right?

I guess we can do that when it will allow reducing the arguments number.

Thanks,

Paolo